API: Convert statement switches to arrow switches - #17534
Open
uros-b wants to merge 1 commit into
Open
Conversation
Converts the statement-form switch blocks in iceberg-api to expression form, clearing the 89 StatementSwitchToExpressionSwitch ErrorProne warnings the module emits and removing the risk of accidental fall-through in the converted code.
uros-b
commented
Aug 5, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
I first spotted this in api/src/main/java/org/apache/iceberg/types/TypeUtil.java, but after a full API module sweep, it seems there are many occurrences... Perhaps this can be split up into a few PRs instead of doing all at once; or if it's too invasive, we can drop the changes altogether - WDYT @szehon-ho?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the statement-form switch blocks in iceberg-api to expression form, clearing the 89
StatementSwitchToExpressionSwitchErrorProne warnings the module emits and removing the risk of accidental fall-through in the converted code.