fix: support untyped NULL input for median - #24104
Open
Sigma-Ma wants to merge 1 commit into
Open
Conversation
Author
|
Hi, this is my first contribution to DataFusion. Could a committer please trigger CI when convenient? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
median(NULL)worked in DataFusion 53 but regressed in DataFusion 54. The untyped NULL argument remainedDataType::Null, causing physical planning to create a median accumulator for an unsupported input type.What changes are included in this PR?
median.Float64.median(NULL).Are these changes tested?
Yes.
cargo fmt --all -- --checkcargo test --profile=ci --test sqllogictests -- aggregate.sltcargo test -p datafusion-functions-aggregatecargo clippy -p datafusion-functions-aggregate --all-targets --all-features -- -D warningsAre there any user-facing changes?
Yes.
median(NULL)now returns a typedFloat64NULL instead of failing during physical execution.