perf: preserve dictionary encoding for btrim, ltrim, and rtrim - #24100
Open
lyne7-sc wants to merge 1 commit into
Open
perf: preserve dictionary encoding for btrim, ltrim, and rtrim#24100lyne7-sc wants to merge 1 commit into
btrim, ltrim, and rtrim#24100lyne7-sc wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24100 +/- ##
==========================================
+ Coverage 80.89% 80.91% +0.01%
==========================================
Files 1102 1102
Lines 376111 377100 +989
Branches 376111 377100 +989
==========================================
+ Hits 304251 305115 +864
- Misses 53753 53787 +34
- Partials 18107 18198 +91 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
character_length,initcap, andreverse#23930CoercionAPI #19458 and String scalar functions should preserve Dictionary encoding for Dictionary-typed inputs #20935Rationale for this change
Previously, coercion materialized dictionary-encoded inputs for
btrim,ltrim, andrtrim. This lost the encoding and evaluated the function for every row instead of once per dictionary value entry.This PR extends dictionary preservation to these trim functions.
What changes are included in this PR?
btrim,ltrim, andrtrim.Are these changes tested?
Yes, covered by slt
Are there any user-facing changes?
These functions now preserve dictionary encoding in their output.
Benchmarks