Skip to content

test(@angular/build): avoid race conditions in incremental-watch e2e test #33815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Aug 7, 2026
Merged

test(@angular/build): avoid race conditions in incremental-watch e2e test #33815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 39 additions & 7 deletions tests/e2e/tests/build/incremental-watch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,32 @@ import { execAndWaitForOutputToMatch, waitForAnyProcessOutputToMatch } from '../

const buildReadyRegEx = /Application bundle generation complete\./;

async function getOutputFiles(
dir: string,
predicate: (files: string[]) => boolean,
timeout = 10_000,
): Promise<string[]> {
const start = Date.now();
while (Date.now() - start < timeout) {
try {
const files = await readdir(dir);
if (predicate(files)) {
return files;
}
} catch (err: any) {
if (err?.code !== 'ENOENT') {
throw err;
}
}
await setTimeout(50);
}

const files = await readdir(dir);
assert(predicate(files), `Condition not met for files in ${dir}: ${JSON.stringify(files)}`);
Comment thread
clydin marked this conversation as resolved.

return files;
}

export default async function () {
const usingApplicationBuilder = getGlobalVariable('argv')['esbuild'];
assert(
Expand All @@ -20,15 +46,17 @@ export default async function () {
['build', '--watch', '--configuration=development'],
buildReadyRegEx,
);
await setTimeout(500);
const initialOutputFiles = await readdir('dist/test-project/browser');
const initialOutputFiles = await getOutputFiles(
'dist/test-project/browser',
(files) => files.length > 0,
);

const originalMain = await readFile('src/main.ts');

// Add a dynamic import to create an additional output chunk
await Promise.all([
waitForAnyProcessOutputToMatch(buildReadyRegEx),
await writeFile(
writeFile(
'src/a.ts',
`
export function sayHi() {
Expand All @@ -38,8 +66,10 @@ export default async function () {
),
appendToFile('src/main.ts', `\nimport('./a').then((m) => m.sayHi());`),
]);
await setTimeout(500);
const intermediateOutputFiles = await readdir('dist/test-project/browser');
const intermediateOutputFiles = await getOutputFiles(
'dist/test-project/browser',
(files) => files.length > initialOutputFiles.length,
);
assert(
initialOutputFiles.length < intermediateOutputFiles.length,
'Additional chunks should be present',
Expand All @@ -50,8 +80,10 @@ export default async function () {
waitForAnyProcessOutputToMatch(buildReadyRegEx),
writeFile('src/main.ts', originalMain),
]);
await setTimeout(500);
const finalOutputFiles = await readdir('dist/test-project/browser');
const finalOutputFiles = await getOutputFiles(
'dist/test-project/browser',
(files) => files.length === initialOutputFiles.length,
);
assert.equal(
initialOutputFiles.length,
finalOutputFiles.length,
Expand Down