Skip to content

refactor(@angular/cli): use Node.js styleText for color helpers #33814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clydin wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

refactor(@angular/cli): use Node.js styleText for color helpers #33814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/cli/src/commands/update/utilities/migration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ import {
FileSystemSchematicDescription,
NodeWorkflow,
} from '@angular-devkit/schematics/tools';
import { color as colors, figures } from 'listr2';

@alan-agius4 alan-agius4 Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For constancy shouldn't this be using the internal color util?

import { SpawnSyncReturns } from 'node:child_process';
import * as semver from 'semver';
import { subscribeToWorkflow } from '../../../command-builder/utilities/schematic-workflow';
import { colors, figures } from '../../../utilities/color';
import { assertIsError } from '../../../utilities/error';
import { writeErrorToLogFile } from '../../../utilities/log-file';
import { formatFiles } from '../../../utilities/prettier';
Expand Down
17 changes: 16 additions & 1 deletion packages/angular/cli/src/utilities/color.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,23 @@
*/

import { WriteStream } from 'node:tty';
import { styleText } from 'node:util';

export { color as colors, figures } from 'listr2';
export const colors = Object.freeze({
black: (text: string) => styleText('black', text),
blue: (text: string) => styleText('blue', text),
bold: (text: string) => styleText('bold', text),
cyan: (text: string) => styleText('cyan', text),
dim: (text: string) => styleText('dim', text),
gray: (text: string) => styleText('gray', text),
green: (text: string) => styleText('green', text),
italic: (text: string) => styleText('italic', text),
magenta: (text: string) => styleText('magenta', text),
red: (text: string) => styleText('red', text),
underline: (text: string) => styleText('underline', text),
white: (text: string) => styleText('white', text),
yellow: (text: string) => styleText('yellow', text),
});
Comment thread
clydin marked this conversation as resolved.

export function supportColor(stream: NodeJS.WritableStream = process.stdout): boolean {
if (stream instanceof WriteStream) {
Expand Down