fix(@angular/build): prevent syntax corruption for Crockford-style enum IIFE - #33791
Merged
Merged
Conversation
…um IIFE When transforming Crockford-style TypeScript enum IIFEs, ensure all leading and trailing parentheses of the expression statement are removed when moving the IIFE call expression to the var initializer. Fixes angular#33785
alan-agius4
added
the
target: minor
alan-agius4
added
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the OXC-based TypeScript enum transformation to correctly handle enums wrapped in parentheses, including Crockford-style IIFEs and nested parentheses, by removing leading/trailing characters and parentheses from the expression statement. It also adds comprehensive unit tests to verify these scenarios. I have no feedback to provide.
clydin
approved these changes
Aug 6, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When transforming Crockford-style TypeScript enum IIFEs (e.g.
(function (E) { ... }(E || (E = {})));), ensure all leading and trailing parentheses of the expression statement are removed when moving the IIFE call expression to the var initializer so no dangling parentheses remain before subsequent statements.Fixes #33785