Isolate DiffRunnerTests from the machine's queue owner - #761
Open
SimonCropp wants to merge 1 commit into
Open
Conversation
Launching sends a real pending move to whatever owns the queue. On a developer box that is the tray, started at login, so accepting the move overwrote the checked in fixtures and discarding it deleted them - DiffRunner.file1.txt had been destroyed that way. A discard also kills the diff tool process the tests assert on. Cut both routes in the module initializer: no tray, and a viewer port nothing is listening on. A failed move send is the end of the road in PendingFiles.AddMove, and only a delete launches a viewer, which nothing here adds. The piper send stays covered by DiffRunnerCanKillTest, which drives a tray under test control. Also run against copies in a temp directory, so the fixtures cannot be touched even if that isolation is later reset. One directory per class, since IsRunning matches the exact command string and WaitForRunning wants the same paths across tests; copied per test, since a discard deletes the temp file and its directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching sends a real pending move to whatever owns the queue. On a developer box that is the tray, started at login, so accepting the move overwrote the checked in fixtures and discarding it deleted them - DiffRunner.file1.txt had been destroyed that way. A discard also kills the diff tool process the tests assert on.
Cut both routes in the module initializer: no tray, and a viewer port nothing is listening on. A failed move send is the end of the road in PendingFiles.AddMove, and only a delete launches a viewer, which nothing here adds. The piper send stays covered by DiffRunnerCanKillTest, which drives a tray under test control.
Also run against copies in a temp directory, so the fixtures cannot be touched even if that isolation is later reset. One directory per class, since IsRunning matches the exact command string and WaitForRunning wants the same paths across tests; copied per test, since a discard deletes the temp file and its directory.