Skip to content

Add input validation to cyclic_sort to prevent invalid inputs - #15009

Open
Gairola788 wants to merge 5 commits into
TheAlgorithms:masterfrom
Gairola788:fix-cyclic-sort-validation
Open

Add input validation to cyclic_sort to prevent invalid inputs#15009
Gairola788 wants to merge 5 commits into
TheAlgorithms:masterfrom
Gairola788:fix-cyclic-sort-validation

Conversation

@Gairola788

@Gairola788 Gairola788 commented Aug 6, 2026

Copy link
Copy Markdown

Describe your change:

Added input validation to the cyclic_sort algorithm to prevent invalid inputs from causing infinite loops or incorrect results.

The function now raises a ValueError when:

  • the input contains duplicate numbers.
  • a number is outside the valid range 1 to n.

Fixes #14898

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes cyclic_sort.py has no input validation, causes infinite loop on invalid input #14898".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 6, 2026
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Aug 6, 2026
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cyclic_sort.py has no input validation, causes infinite loop on invalid input

1 participant