Skip to content

refactor(routes/partners.railway): drop lucide-era icon aliases and fix the check weight - #1114

Merged
sukvvon merged 1 commit into
mainfrom
fix/railway-partner-icons
Aug 5, 2026
Merged

refactor(routes/partners.railway): drop lucide-era icon aliases and fix the check weight#1114
sukvvon merged 1 commit into
mainfrom
fix/railway-partner-icons

Conversation

@sukvvon

@sukvvon sukvvon commented Aug 5, 2026

Copy link
Copy Markdown
Member

Follow-up to #1113, which moved the Netlify partner page off lucide-react. The Railway page had migrated to Phosphor earlier but kept two artefacts from that move.

strokeWidth={3} never applied

The check badge carried strokeWidth={3} — a Lucide prop. Phosphor's IconProps has no strokeWidth; it exposes weight, and each weight ships a different SVG path. The prop was silently dropped and the check rendered at regular.

Confirmed by reading the rendered path:

d attribute Stroke
strokeWidth={3} M229.66,77.66l-128,128a8,8,… 8 — regular
weight="bold" M232.49,80.49l-128,128a12,12,… 12 — bold

So this restores the emphasis the badge had under Lucide rather than changing the design.

Aliases

-  CurrencyDollarIcon as DollarSign,
-  ChartLineIcon as LineChart,
-  ArrowUUpLeftIcon as Undo2,
+  CurrencyDollarIcon,
+  ChartLineIcon,
+  ArrowUUpLeftIcon,

These preserved the old Lucide names. With #1113 landed, the two partner pages otherwise use identical Phosphor imports, so keeping the aliases here meant the same icon went by two names depending on the file. Call sites updated and the import block re-sorted.

Verified

tsc and oxlint --type-aware clean. Rendered the page locally and diffed the badge's SVG path before and after to confirm weight takes effect — the visual difference at 10px is too small to judge from a screenshot alone.

Summary by CodeRabbit

  • Refactor
    • Updated interface icons to use current icon names.
    • No visible changes to functionality or rendering.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 11d911a2-173a-4d9f-ab5e-448fec815d73

📥 Commits

Reviewing files that changed from the base of the PR and between 3321b67 and fe940ae.

📒 Files selected for processing (1)
  • src/routes/partners.railway.tsx

📝 Walkthrough

Walkthrough

The Railway partner route now imports current Phosphor icon names directly. Icon usages and the check icon property were updated without changing behavior or rendering.

Changes

Railway partner icon updates

Layer / File(s) Summary
Update Phosphor icon imports and usage
src/routes/partners.railway.tsx
Replaces aliased chart, undo, dollar, and check icons with current Phosphor names and properties.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: abeuty, tannerlinsley

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: removing icon aliases and correcting the check icon weight.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/railway-partner-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com fe940ae Commit Preview URL

Branch Preview URL
Aug 05 2026, 02:53 AM

@sukvvon sukvvon self-assigned this Aug 5, 2026
@sukvvon
sukvvon merged commit 5574c91 into main Aug 5, 2026
7 checks passed
@sukvvon
sukvvon deleted the fix/railway-partner-icons branch August 5, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants