Fix FrameworkIconTabs vertical overflow - #1085
Merged
Merged
Conversation
Co-authored-by: iftype <conditionaltype@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesFramework icon tabs
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add
overflow-y-hiddentoFrameworkIconTabs, matching the existing overflow contract used by the other horizontally scrollable tab components.Evidence and impact
The container currently enables horizontal overflow without suppressing the transient vertical overflow produced while scrolling on mobile. This causes the layout shift reported in #954.
src/components/markdown/Tabs.tsxandFileTabs.tsxalready use the sameoverflow-x-auto overflow-y-hiddenpairing.Closes #954.
Validation
pnpm test— TypeScript and type-aware lint clean; 135 tests (134 passed, 1 skipped)git diff --checkRisk
Low. The change only clips vertical overflow on the existing horizontal tab scroller; caller-provided classes can still override it through
twMerge.Summary by CodeRabbit