Skip to content

Fix FrameworkIconTabs vertical overflow - #1085

Merged
tannerlinsley merged 1 commit into
mainfrom
agent/fix-framework-tabs-overflow
Jul 31, 2026
Merged

Fix FrameworkIconTabs vertical overflow#1085
tannerlinsley merged 1 commit into
mainfrom
agent/fix-framework-tabs-overflow

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Jul 31, 2026

Copy link
Copy Markdown
Member

What changed

Add overflow-y-hidden to FrameworkIconTabs, matching the existing overflow contract used by the other horizontally scrollable tab components.

Evidence and impact

The container currently enables horizontal overflow without suppressing the transient vertical overflow produced while scrolling on mobile. This causes the layout shift reported in #954. src/components/markdown/Tabs.tsx and FileTabs.tsx already use the same overflow-x-auto overflow-y-hidden pairing.

Closes #954.

Validation

  • pnpm test — TypeScript and type-aware lint clean; 135 tests (134 passed, 1 skipped)
  • commit hook reran formatting and the full test gate successfully
  • git diff --check

Risk

Low. The change only clips vertical overflow on the existing horizontal tab scroller; caller-provided classes can still override it through twMerge.

Summary by CodeRabbit

  • Style
    • Updated tab navigation styling to prevent unwanted vertical overflow while preserving horizontal scrolling.

Co-authored-by: iftype <conditionaltype@gmail.com>
@tannerlinsley tannerlinsley added the source-audit Tracked by the automated source audit label Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fcd0828b-5abd-4f4a-ba9e-52ed504dd39a

📥 Commits

Reviewing files that changed from the base of the PR and between 0ba1117 and b840b14.

📒 Files selected for processing (1)
  • src/components/FrameworkIconTabs.tsx

📝 Walkthrough

Walkthrough

FrameworkIconTabs now hides vertical overflow on its tab container while preserving horizontal scrolling.

Changes

Framework icon tabs

Layer / File(s) Summary
Contain vertical tab overflow
src/components/FrameworkIconTabs.tsx
The tab container adds overflow-y-hidden alongside horizontal scrolling styles.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing vertical overflow in FrameworkIconTabs.
Linked Issues check ✅ Passed The PR adds overflow-y-hidden to FrameworkIconTabs, meeting issue #954 and preventing mobile vertical layout shifts.
Out of Scope Changes check ✅ Passed The PR contains only the scoped one-line styling change required by issue #954.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-framework-tabs-overflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley
tannerlinsley merged commit 18eaf27 into main Jul 31, 2026
6 checks passed
@tannerlinsley
tannerlinsley deleted the agent/fix-framework-tabs-overflow branch July 31, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source-audit Tracked by the automated source audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: missing overflow-y-hidden in FrameworkIconTabs (one-liner fix)

1 participant