fix(table-core): toggle group column visibility - #6442
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughGrouped-column visibility toggles now update each hideable leaf column instead of storing visibility under the group ID. Tests cover explicit hiding, inferred toggling, and non-hideable leaves. ChangesColumn visibility
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 5fd708a
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Group columns already derive
getIsVisible()from their children, buttoggleVisibility()wrote the group ID intocolumnVisibility. Since visibility state is evaluated at the leaf level, that entry had no effect and the group remained visible. This keeps the existing leaf-based state model and makes the two group APIs consistent.Validation
pnpm nx run @tanstack/table-core:test:lib(52 files, 1006 tests)pnpm nx run @tanstack/table-core:test:typespnpm nx run @tanstack/table-core:test:eslintCloses #5497
Summary by CodeRabbit
Bug Fixes
Tests