Skip to content

PREQ-7838 Add Artifactory Env Exports to config-pip - #333

Open
alex-meseldzija-sonarsource wants to merge 2 commits into
masterfrom
alex/pip-config-global-env
Open

PREQ-7838 Add Artifactory Env Exports to config-pip#333
alex-meseldzija-sonarsource wants to merge 2 commits into
masterfrom
alex/pip-config-global-env

Conversation

@alex-meseldzija-sonarsource

@alex-meseldzija-sonarsource alex-meseldzija-sonarsource commented Aug 5, 2026

Copy link
Copy Markdown

Part of RC-16

When using pip, a repo can have a Pipfile which needs to be routed through repox via the env.

Without this change, everywhere we call config-pip we also have to retrieve our own artifactory tokens and export them to the env.

This solves the problem centrally.

@alex-meseldzija-sonarsource
alex-meseldzija-sonarsource requested a review from a team as a code owner August 5, 2026 15:23
Copilot AI review requested due to automatic review settings August 5, 2026 15:23
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Add Artifactory Env Exports to config-pip PREQ-7838 Add Artifactory Env Exports to config-pip Aug 5, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Aug 5, 2026

Copy link
Copy Markdown

PREQ-7838

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the config-pip composite action to export Artifactory authentication variables into the job environment (via GITHUB_ENV) and updates the documentation to reflect the newly exported variables.

Changes:

  • Export ARTIFACTORY_URL, ARTIFACTORY_USERNAME, ARTIFACTORY_ACCESS_TOKEN (and deprecated aliases) into GITHUB_ENV from config-pip.
  • Document the additional output environment variables for config-pip in the README.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
README.md Documents newly exported Artifactory-related environment variables for config-pip.
config-pip/action.yml Adds a step to export Artifactory auth environment variables (plus deprecated aliases) into GITHUB_ENV.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread config-pip/action.yml
@gitar-bot

gitar-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds Artifactory environment exports to config-pip to route Pipfiles through repox centrally. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Suppressed comments (1)

README.md:1250

  • Typo in the example abbreviation: “E.x.” should be “e.g.” (this same typo appears in other duplicated tables in the README, so you may want to update those too for consistency).
| `ARTIFACTORY_URL`             | Artifactory (Repox) URL. E.x.: `https://repox.jfrog.io/artifactory` |

Comment thread config-pip/action.yml
Comment thread config-pip/action.yml
run: |
echo "ARTIFACTORY_URL=$ARTIFACTORY_URL" >> "$GITHUB_ENV"
echo "ARTIFACTORY_USERNAME=$ARTIFACTORY_USERNAME" >> "$GITHUB_ENV"
echo "ARTIFACTORY_ACCESS_USERNAME=$ARTIFACTORY_USERNAME" >> "$GITHUB_ENV" # deprecated, backward compliance

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-meseldzija-sonarsource do you need the deprecated variable names? ARTIFACTORY_ACCESS_USERNAME and ARTIFACTORY_PASSWORD.
They were known to be used by Maven projects, thus their presence in maven-config, but I would not add them here if not already in use by a big codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants