PREQ-7838 Add Artifactory Env Exports to config-pip - #333
PREQ-7838 Add Artifactory Env Exports to config-pip#333alex-meseldzija-sonarsource wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the config-pip composite action to export Artifactory authentication variables into the job environment (via GITHUB_ENV) and updates the documentation to reflect the newly exported variables.
Changes:
- Export
ARTIFACTORY_URL,ARTIFACTORY_USERNAME,ARTIFACTORY_ACCESS_TOKEN(and deprecated aliases) intoGITHUB_ENVfromconfig-pip. - Document the additional output environment variables for
config-pipin the README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Documents newly exported Artifactory-related environment variables for config-pip. |
| config-pip/action.yml | Adds a step to export Artifactory auth environment variables (plus deprecated aliases) into GITHUB_ENV. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Review ✅ ApprovedAdds Artifactory environment exports to config-pip to route Pipfiles through repox centrally. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
README.md:1250
- Typo in the example abbreviation: “E.x.” should be “e.g.” (this same typo appears in other duplicated tables in the README, so you may want to update those too for consistency).
| `ARTIFACTORY_URL` | Artifactory (Repox) URL. E.x.: `https://repox.jfrog.io/artifactory` |
| run: | | ||
| echo "ARTIFACTORY_URL=$ARTIFACTORY_URL" >> "$GITHUB_ENV" | ||
| echo "ARTIFACTORY_USERNAME=$ARTIFACTORY_USERNAME" >> "$GITHUB_ENV" | ||
| echo "ARTIFACTORY_ACCESS_USERNAME=$ARTIFACTORY_USERNAME" >> "$GITHUB_ENV" # deprecated, backward compliance |
There was a problem hiding this comment.
@alex-meseldzija-sonarsource do you need the deprecated variable names? ARTIFACTORY_ACCESS_USERNAME and ARTIFACTORY_PASSWORD.
They were known to be used by Maven projects, thus their presence in maven-config, but I would not add them here if not already in use by a big codebase.



Part of RC-16
When using pip, a repo can have a Pipfile which needs to be routed through repox via the env.
Without this change, everywhere we call config-pip we also have to retrieve our own artifactory tokens and export them to the env.
This solves the problem centrally.