chore: Add job to generate api docs - #62
Open
marikaner wants to merge 4 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yamaceay
reviewed
Aug 14, 2026
yamaceay
left a comment
yamaceay
left a comment
Contributor
There was a problem hiding this comment.
Nice job, just some minor feedbacks :)
| env: | ||
| TAG: ${{ github.ref_name }} | ||
| run: | | ||
| BRANCH="api-docs-python-$TAG-$(date +%Y%m%d)" |
Contributor
There was a problem hiding this comment.
q: I wanted to ask whether it could be a problem that we generate multiple api docs per day. Maybe, it makes sense to add a 5-6 char long salt at the end to randomize it?
Contributor
There was a problem hiding this comment.
pp: I think we can stack #64 on top of this PR too, since it affects similar files.
| permission-pull-requests: write | ||
|
|
||
| - name: Setup | ||
| uses: SAP/ai-sdk-python/.github/actions/setup@main |
Contributor
There was a problem hiding this comment.
q: Is it intended that we don't pin this branch to a SHA?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.