Flip Selection Feature - #555
Draft
RaviScriptDev wants to merge 11 commits into
Draft
Conversation
also, I can probably make it cleaner
…the vertical flip for-loop. To remove the code duplication, I merged these two for-loops. To select what mode (vertical or horizontal) the flip will use, before the loop, I defined and calculated two variables: `outerloop_count` and `innerloop_count` These two variables basically, one the two is set to current_song.selection_(l or h) divided by 2. The other is set to `row` or `column`. The same thing is done for the target_row and target_column: one of these two has the value calculated, the other is just `row` or `column`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an useful feature. It adds the ability to flip the notes in the current selection.
Details:
Ctrl+ Hto do a horizontal flip andCtrl + Jto do a vertical flip, so far)