fix: fix outdated reg names in deployment samples - #189
Open
Il Harper (ilharp) wants to merge 1 commit into
Open
fix: fix outdated reg names in deployment samples#189Il Harper (ilharp) wants to merge 1 commit into
Il Harper (ilharp) wants to merge 1 commit into
Conversation
Currently deployment samples `WV2DeploymentWiXCustomActionSample` and `WV2DeploymentWiXBurnBundleSample` use the reg name `EBWebView` for registry searching, but this entry has already disappeared in recent versions of WVRT (also disappeared in Edge Stable).   Changed them to `pv`, consistent with `WV2DeploymentVSInstallerSample`. Also I noticed that these three registry searches were introduced in the same PR (MicrosoftEdge#56). Are there any special considerations for the inconsistency here? Related commit: MicrosoftEdge@8402697
|
Il Harper (@ilharp) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently deployment samples
WV2DeploymentWiXCustomActionSampleandWV2DeploymentWiXBurnBundleSampleuse the reg nameEBWebViewfor registry searching, but this entry has already disappeared in recent versions of WVRT (also disappeared in Edge Stable).Changed them to
pv, consistent withWV2DeploymentVSInstallerSample.Also I noticed that these three registry searches were introduced in the same PR (#56). Are there any special considerations for the inconsistency here?
Related commit:
8402697