Skip to content

fix: make CachingOpenAIModel._map_messages version-adaptive #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiberiFatali wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

fix: make CachingOpenAIModel._map_messages version-adaptive #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions codewiki/src/be/llm_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

Supports multiple providers: openai-compatible, anthropic, bedrock, azure-openai.
"""
import inspect
import logging
from typing import Optional

Expand Down Expand Up @@ -148,10 +149,16 @@ def __init__(self, model_name, *, prompt_caching=True, cache_registry_key="", **
def _prompt_caching_active(self) -> bool:
return self._prompt_caching_enabled and self._cache_registry_key not in _CACHE_UNSUPPORTED

async def _map_messages(self, messages, model_request_parameters, *, model_settings=None):
openai_messages = await super()._map_messages(
messages, model_request_parameters, model_settings=model_settings
)
async def _map_messages(self, messages, model_request_parameters=None, *, model_settings=None):
base = OpenAIChatModel._map_messages
base_params = set(inspect.signature(base).parameters)
if "model_request_parameters" in base_params:
openai_messages = await super()._map_messages(
messages, model_request_parameters, model_settings=model_settings
)
else:
# pydantic-ai < 1.107: base _map_messages accepts only messages.
openai_messages = await super()._map_messages(messages)
if self._prompt_caching_active:
# Breakpoint 1: last system/developer message (covers tools + system).
for message in reversed(openai_messages):
Expand Down