Fix fiberSet serializes itself as FiberMap - #7062
Conversation
🦋 Changeset detectedLatest commit: db04308 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Important
The regression test added here is correct, but the implementation fix is still missing. packages/effect/src/FiberSet.ts still returns _id: "FiberMap" at its toJSON method, so the new test will fail against the current branch.
Reviewed changes
This PR adds a focused regression test in packages/effect/test/FiberSet.test.ts asserting that FiberSet.toJSON() carries _id: "FiberSet". The test is well-placed and directly encodes the expected behavior described in the PR body. However, the corresponding source-code change in packages/effect/src/FiberSet.ts is not present in the diff, so the PR title "Fix fiberSet serializes itself as FiberMap" is premature.
packages/effect/test/FiberSet.test.ts— addsit.effect("identifies FiberSet in JSON", ...)coveringtoJSON()._id.
⚠️ Implementation fix missing
packages/effect/src/FiberSet.ts:103 currently returns _id: "FiberMap". It must be changed to _id: "FiberSet" for the new test to pass and for toString / Node inspection output to correctly identify the abstraction.
A patch-level changeset for effect should accompany the source fix, since this is a user-visible runtime behavior correction.
@v0 or keep the SHA fresh with Dependabot | Fix it ➔ | View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Since the prior pullfrog review, the PR now includes the missing implementation fix and a patch changeset.
packages/effect/src/FiberSet.ts— changed the_idreturned bytoJSON()from"FiberMap"to"FiberSet"..changeset/fix-fiberset-json-id.md— added a patch changeset for theeffectpackage describing the inspectable JSON identity fix.
@v0 or keep the SHA fresh with Dependabot | View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|

Summary
FiberSet.toJSON()to identify the abstraction asFiberSetinstead ofFiberMap.packages/effect/test/FiberSet.test.tssuite.Validation
pnpm test --run packages/effect/test/FiberSet.test.tspnpm test --run packages/effect/testpnpm lintpnpm checkAudit provenance
17f0b91a243ccfe4a38d27debdc983adf434e738effect-5bde654107f0fb71Closes EFF-489