Restore .NET Framework 4.8 compatibility - #41
Open
xincheng213618 wants to merge 1 commit into
Open
Conversation
Revert the interdependent .NET 10/Skia migration from PR DebugST#37 and restore the tested PR DebugST#32 source tree. Add the missing solution platform build mappings so Any CPU, x86, and Mixed Platforms all build the intended projects.
xincheng213618
marked this pull request as ready for review
August 7, 2026 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ST.Library.UIandWinNodeEditorDemoto .NET Framework 4.8 and their original WinForms/GDI public contracts.WpfNodeEdittorDemosources so they match the original library contract.Any CPU,x86, andMixed Platformsall build the complete intended project set.Why a full revert
#37 converted the existing WinForms library from .NET Framework 4.8 to .NET 10 and changed public drawing/control contracts from GDI/WinForms types to Skia types. Its final merge also left the solution unbuildable (including malformed code in
STNodeEditor.csand a framework mismatch with the existing WPF demo).The commits in #37/#38 form one interdependent rendering migration rather than independent fixes. Reverting the merge as a unit avoids keeping partial API changes and returns the original projects to the tested #32 baseline. The new native WPF implementation remains isolated in #40.
Solution configuration
ST.Library.UIinto Debug/Releasex86builds using itsAny CPUproject configuration.WinNodeEditorDemointo Debug/ReleaseAny CPUbuilds using itsx86project configuration.Mixed Platformsmappings are preserved.Validation