Alexeyk/bump spotbugs - #11879
Conversation
# Conflicts: # dd-java-agent/agent-crashtracking/src/main/java/datadog/crashtracking/CrashUploader.java # gradle/libs.versions.toml
# Conflicts: # gradle/libs.versions.toml
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
Review requested for every new suppression.
There was a problem hiding this comment.
More details
This PR safely bumps SpotBugs versions (plugin 6.5.5→6.5.6, annotations 4.9.8→4.10.2) and adds @SuppressFBWarnings annotations for pre-existing synchronization patterns in agent-internal code. No production behavior changes—annotations are compile-time markers only. All imports, syntax, and version compatibility verified.
📊 Validated against 5 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit b72f8de · What is Autotest? · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b72f8dea84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (338.945 µs) : 317, 361
. : milestone, 339,
basic (296.866 µs) : 290, 304
. : milestone, 297,
loop (8.988 ms) : 8982, 8993
. : milestone, 8988,
section candidate
noprobe (335.219 µs) : 304, 367
. : milestone, 335,
basic (297.244 µs) : 291, 304
. : milestone, 297,
loop (8.983 ms) : 8979, 8988
. : milestone, 8983,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Bumps version:
6.5.5→6.5.6)spotbugs-annotations(4.9.8→4.10.2)Motivation
Keep SpotBugs current so
spotbugsMainstays green on the latest detectors and we pick up upstream fixes.Additional Notes
No production behavior changes — annotation and comment additions only.
I will mention in PR comments for codeowners to review findings.