Skip to content

Alexeyk/bump spotbugs - #11879

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 20 commits into
masterfrom
alexeyk/bump-spotbugs
Aug 7, 2026
Merged

Alexeyk/bump spotbugs#11879
gh-worker-dd-mergequeue-cf854d[bot] merged 20 commits into
masterfrom
alexeyk/bump-spotbugs

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Bumps version:

  • SpotBugs Gradle plugin (6.5.56.5.6)
  • spotbugs-annotations (4.9.84.10.2)

Motivation

Keep SpotBugs current so spotbugsMain stays green on the latest detectors and we pick up upstream fixes.

Additional Notes

No production behavior changes — annotation and comment additions only.
I will mention in PR comments for codeowners to review findings.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jul 7, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling dependencies labels Jul 7, 2026

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review requested for every new suppression.

Comment thread internal-api/src/main/java/datadog/trace/util/UnsafeUtils.java
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review July 7, 2026 19:54
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners July 7, 2026 19:54
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from PerfectSlayer and ojung and removed request for a team July 7, 2026 19:54
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from mtoffl01 and removed request for a team July 7, 2026 19:54

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

This PR safely bumps SpotBugs versions (plugin 6.5.5→6.5.6, annotations 4.9.8→4.10.2) and adds @SuppressFBWarnings annotations for pre-existing synchronization patterns in agent-internal code. No production behavior changes—annotations are compile-time markers only. All imports, syntax, and version compatibility verified.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit b72f8de · What is Autotest? · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b72f8dea84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread gradle/libs.versions.toml
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: dependencies Dependencies related changes and removed dependencies labels Jul 7, 2026
@DataDog DataDog deleted a comment from dd-octo-sts Bot Jul 7, 2026
@datadog-datadog-prod-us1-2

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Jul 20, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1786062731 1786063077
end_time 2026-08-07T00:33:38 2026-08-07T00:39:22
git_branch master alexeyk/bump-spotbugs
git_commit_sha d4d9d24 600e085
start_time 2026-08-07T00:32:12 2026-08-07T00:37:58
See matching parameters
Baseline Candidate
ci_job_id 1931235958 1931235958
ci_pipeline_id 129548176 129548176
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1786062013 1786062013

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-17.009µs; +20.595µs] or [-5.873%; +7.111%]
unstable
[-32.588µs; +25.136µs] or [-9.614%; +7.416%]
unstable
[-50.076µs; +27.477µs] or [-13.813%; +7.579%]
unstable
[-97.095µs; +130.964µs] or [-8.282%; +11.171%]
same
scenario:basic same same same unstable
[-198.213µs; +144.893µs] or [-18.041%; +13.188%]
unstable
[-137.324op/s; +137.324op/s] or [-5.493%; +5.493%]
scenario:loop unsure
[-6.914µs; -2.272µs] or [-0.078%; -0.026%]
same unsure
[-13.390µs; -4.655µs] or [-0.148%; -0.051%]
same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (338.945 µs) : 317, 361
.   : milestone, 339,
basic (296.866 µs) : 290, 304
.   : milestone, 297,
loop (8.988 ms) : 8982, 8993
.   : milestone, 8988,
section candidate
noprobe (335.219 µs) : 304, 367
.   : milestone, 335,
basic (297.244 µs) : 291, 304
.   : milestone, 297,
loop (8.983 ms) : 8979, 8988
.   : milestone, 8983,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 338.945 µs [316.56 µs, 361.329 µs]
basic 296.866 µs [289.997 µs, 303.735 µs]
loop 8.988 ms [8.982 ms, 8.993 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 335.219 µs [303.522 µs, 366.916 µs]
basic 297.244 µs [290.69 µs, 303.798 µs]
loop 8.983 ms [8.979 ms, 8.988 ms]

@dd-octo-sts

dd-octo-sts Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.79 s 14.64 s [+0.3%; +1.8%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.64 s 13.74 s [-1.5%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 16.88 s 16.74 s [-0.1%; +1.8%] (no difference)
startup:petclinic:iast:Agent 16.98 s 16.99 s [-0.9%; +0.8%] (no difference)
startup:petclinic:profiling:Agent 16.61 s 16.36 s [-3.1%; +6.1%] (no difference)
startup:petclinic:sca:Agent 16.83 s 16.56 s [+0.6%; +2.6%] (maybe worse)
startup:petclinic:tracing:Agent 16.13 s 16.07 s [-0.7%; +1.5%] (no difference)

Commit: 600e085b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested a review from a team as a code owner August 4, 2026 21:30
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from leoromanovsky and vjfridge and removed request for a team August 4, 2026 21:30
@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-07 01:57:34 UTC ℹ️ Start processing command /merge


2026-08-07 01:57:39 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-08-07 02:47:53 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 4125ce1 into master Aug 7, 2026
601 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/bump-spotbugs branch August 7, 2026 02:47
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants