terminal_exit_regression fails on macOS: test never sends the snapshot_request handshake

[pandalaohe]

Description

tests/terminal_exit_regression.rs fails on macOS: wait_for_shell_prompt() always exhausts its 15-second deadline because the test never performs the snapshot_request handshake that the real client performs on connect.

Linux CI does not catch this because ci.yml runs cargo test --lib, which excludes the tests/ directory entirely. Only windows-ci.yml runs cargo test --workspace --all-targets.

Steps to reproduce

On macOS, from a clean checkout of dev:

cargo test --test terminal_exit_regression

The test hangs for 15 seconds and then fails, having collected no output frames.

Cause

After opening the WebSocket, the test calls wait_for_shell_prompt() (line 357) and waits for a message of type: "output". But the first and only ws.send in the test happens at line 359 — after that wait — and sends input, not a handshake:

wait_for_shell_prompt(&mut ws).await?;          // 357: waits for output
ws.send(Message::Text(                          // 359: first ws.send, too late
    serde_json::json!({ "type": "input", "data": "exit\r" }).to_string(),
)).await?;

The real client sends snapshot_request on connect — the protocol type is declared in frontend/src/types/protocol.ts:20, useTerminal.ts:891 explicitly tracks that the client "owes the server a snapshot_request", and the server handles it in src/ws/mod.rs. Without it the server emits nothing, so the test's 15-second deadline expires.

Suggested fix

Send the handshake before waiting for the prompt:

ws.send(Message::Text(
    serde_json::json!({ "type": "snapshot_request", "cols": 80, "rows": 24 }).to_string(),
))
.await?;
wait_for_shell_prompt(&mut ws).await?;

Verified locally on a clean worktree at 156c9973: without the handshake the test fails after the full 15-second timeout; with it the test passes in about 1.5 seconds.

Related: CI coverage gap

ci.yml line 74 runs cargo test --lib, so no integration test under tests/ runs on Linux CI. If that is unintentional, cargo test --all-targets there would surface this class of failure. Filing that observation here rather than as a separate issue since the two are connected — happy to split it out if you'd prefer.

Environment

• Branch dev @ 156c9973, verified on an unmodified worktree
• macOS

[xichan96]

感谢详细的根因定位和修复建议，完全正确！已在 dev 分支修复（93e5edc）：

1. tests/terminal_exit_regression.rs 在 connect_async 之后、wait_for_shell_prompt 之前补发 snapshot_request 握手（cols=80, rows=24），服务端就会正常推 output 帧
2. .github/workflows/ci.yml 从 cargo test --lib 改为 cargo test --all-targets，让 tests/ 下的集成测试在 Linux CI 也能跑到，避免类似 regression 漏检（之前只有 Windows CI 跑 --all-targets）

本地验证：修复前测试 17.03s FAILED（output so far: ""，与你的报告一致），修复后 2.05s 通过。