GitHub Enterprise: PR enrichment fails because PullRequest.stackEntry is queried unconditionally in 7.3.x

[alexander-yu]

🔍 Is there already an issue for your problem?

• I have checked older issues, open and closed

📝 Description

It looks like starting from 7.3.0, enrichGitHubNotifications fails with the following error: GraphQL request returned errors: Field 'stackEntry' doesn't exist on type 'PullRequest'

This is causing the status icons to show in grey (inspecting in DevTools indicates that they're labeled with text-gitify-icon-muted)

AFAIK though there isn't a known upcoming version of GHE that will include stacked PRs but hopefully soon

🪜 Steps To Reproduce

1. Connect gitify to GHE instance
2. Open DevTools
3. Inspect console when retrieving notifications

🪵 Log Excerpts

No response

Gitify Version

7.3.2

Operating System

macOS

GitHub Account

GitHub Enterprise Server

📸 Screenshots

No response

[setchy]

That's for reporting. We'll have a fix out soon

[sphinxrave]

Hey @setchy thanks for taking a stab but unfortunately the issue does not seem to be resolved, on 7.3.3 i still see a lot of the same stackEntry GraphQL error.

[setchy]

Hey @setchy thanks for taking a stab but unfortunately the issue does not seem to be resolved, on 7.3.3 i still see a lot of the same stackEntry GraphQL error.

GHE or GitHub Cloud?

[sphinxrave]

GHE, the error says

... GraphQL request returned errors: Field 'stackEntry' doesn't exist on type 'PullRequest'; Variable $includeStackEntry is declared by FetchPullRequestByNumber but not used

[sphinxrave]

asked Opus coz not super familiar with GraphQL and your code looks fine-ish:

The trap: @include/@Skip don't help here. They're execution directives, evaluated after validation. Sending includeStackEntry: false still fails, because the server validates the whole document against the schema before it ever looks at the variable values. A field the server doesn't know about has to be absent from the query text entirely.

... you need two document variants, not a directive.

sounds legit (sorry)