refactor(auth/repositories): drop redundant 'Capability[]' casts (#1120)

Author: sukvvon

src/auth/repositories.server.ts

@@ -118,7 +118,7 @@ export class DrizzleUserRepository implements IUserRepository {
       image: user.image,
       oauthImage: user.oauthImage,
       displayUsername: user.displayUsername,
-      capabilities: user.capabilities as Capability[],
+      capabilities: user.capabilities,
       adsDisabled: user.adsDisabled,
       interestedInHidingAds: user.interestedInHidingAds,
       lastUsedFramework: user.lastUsedFramework,
@@ -241,16 +241,13 @@ export class DrizzleCapabilitiesRepository implements ICapabilitiesRepository {
     }
 
     // Extract user capabilities (same for all rows)
-    const directCapabilities = (result[0]?.userCapabilities ||
-      []) as Capability[]
+    const directCapabilities = result[0]?.userCapabilities ?? []
 
     // Collect all role capabilities from all rows
     const roleCapabilities = result
       .map((r) => r.roleCapabilities)
-      .filter(
-        (caps): caps is Capability[] => caps !== null && Array.isArray(caps),
-      )
-      .flat() as Capability[]
+      .filter((caps) => caps !== null)
+      .flat()
 
     // Union of direct capabilities and role capabilities
     const effectiveCapabilities = Array.from(
@@ -288,18 +285,15 @@ export class DrizzleCapabilitiesRepository implements ICapabilitiesRepository {
 
       // Store direct capabilities (same for all rows of the same user)
       if (!userCapabilitiesMap[userId]) {
-        userCapabilitiesMap[userId] = (row.userCapabilities ||
-          []) as Capability[]
+        userCapabilitiesMap[userId] = row.userCapabilities ?? []
       }
 
       // Collect role capabilities
-      if (row.roleCapabilities && Array.isArray(row.roleCapabilities)) {
+      if (row.roleCapabilities) {
         if (!userRoleCapabilitiesMap[userId]) {
           userRoleCapabilitiesMap[userId] = []
         }
-        userRoleCapabilitiesMap[userId].push(
-          ...(row.roleCapabilities as Capability[]),
-        )
+        userRoleCapabilitiesMap[userId].push(...row.roleCapabilities)
       }
     }