From 1df700c921da2300d4bf28d1b1f3ccd7c24d750e Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Mon, 10 Aug 2026 13:40:11 +0200 Subject: [PATCH 1/2] fix: silence Coverity UNUSED_VALUE in __create_descriptor_1d The value returned by DftiFreeDescriptor on the reallocate path is consumed only by a debug-only assert(status == 0). Under NDEBUG the assert is stripped, so the store is dead before the unconditional status = 0 reset, which Coverity flags as UNUSED_VALUE (one CID per .c.src template instantiation). Mark the value as intentionally unused with (void)status to make the intent explicit and clear the finding. --- CHANGELOG.md | 1 + mkl_fft/src/mklfft.c.src | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2541b671..2dc15223 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed ### Fixed +* Silenced a Coverity `UNUSED_VALUE` finding in `__create_descriptor_1d` by marking the `DftiFreeDescriptor` status (used only by a debug-only `assert`) as intentionally unused ## [2.3.2] - 2026-08-04 diff --git a/mkl_fft/src/mklfft.c.src b/mkl_fft/src/mklfft.c.src index 6bbe33b8..8d9b42c2 100644 --- a/mkl_fft/src/mklfft.c.src +++ b/mkl_fft/src/mklfft.c.src @@ -170,6 +170,7 @@ __create_descriptor_1d_@prec@_@domain@(MKL_LONG len, @sc_t@ fsc, @sc_t@ bsc, Dft if(dfti_cache->hand) { status = DftiFreeDescriptor(&(dfti_cache->hand)); assert(status == 0); + (void)status; /* used only by assert; ignored under NDEBUG */ } status = 0; From 59f117845c13f70c4520de89baa960658ab761fd Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Mon, 10 Aug 2026 13:41:24 +0200 Subject: [PATCH 2/2] docs: add PR reference to changelog entry --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2dc15223..ae806e62 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed ### Fixed -* Silenced a Coverity `UNUSED_VALUE` finding in `__create_descriptor_1d` by marking the `DftiFreeDescriptor` status (used only by a debug-only `assert`) as intentionally unused +* Silenced a Coverity `UNUSED_VALUE` finding in `__create_descriptor_1d` by marking the `DftiFreeDescriptor` status (used only by a debug-only `assert`) as intentionally unused [gh-365](https://github.com/IntelPython/mkl_fft/pull/365) ## [2.3.2] - 2026-08-04